Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error thrown when queue deleted in amqplib 0.10.0 #303

Merged
merged 1 commit into from Oct 24, 2022

Conversation

luddd3
Copy link
Collaborator

@luddd3 luddd3 commented Oct 24, 2022

Fixes #301

@luddd3 luddd3 requested a review from jwalton October 24, 2022 11:36
@jwalton jwalton merged commit 7a430ef into jwalton:master Oct 24, 2022
@jwalton
Copy link
Owner

jwalton commented Oct 24, 2022

🎉 This PR is included in version 4.1.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@@ -759,15 +759,15 @@ export default class ChannelWrapper extends EventEmitter {
if (!msg) {
consumer.consumerTag = null;
this._reconnectConsumer(consumer).catch((err) => {
if (err.isOperational && err.message.includes('BasicConsume; 404')) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like amqplib never throws errors with isOperational any more. Upgrading to 0.10.3 in this repo causes this test to fail because of this. (I'll push a fix for that one in just a sec...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Null Message Exception for 404 Errors Skipped in amqplib >= 0.10.0
2 participants