Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"prepublish" script ignored in favor of "prepare" script in future npm #190

Merged

Conversation

billiegoose
Copy link
Contributor

$ npm install
npm WARN prepublish-on-install As of npm@5, prepublish scripts are deprecated.
npm WARN prepublish-on-install Use prepare for build steps and prepublishOnly for upload-only.
npm WARN prepublish-on-install See the deprecation note in npm help scripts for more information.

Probably my smallest PR ever.

@jvilk
Copy link
Owner

jvilk commented Aug 1, 2017

Does this make dist run twice during npm install and npm publish? It doesn't look like there's any way around it, and the documentation is quite confusing, so I'll merge this.

@jvilk jvilk merged commit df29939 into jvilk:master Aug 1, 2017
@billiegoose
Copy link
Contributor Author

I don't think it ran twice on npm install. I wouldn't know whether it runs twice on npm publish. I'm sure we'll hear more noise about this as npm6 and higher come along.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants