Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests failed on Safari Browser #179

Closed
nidhimundra opened this issue Jun 2, 2017 · 2 comments
Closed

Tests failed on Safari Browser #179

nidhimundra opened this issue Jun 2, 2017 · 2 comments
Labels

Comments

@nidhimundra
Copy link

nidhimundra commented Jun 2, 2017

On running tests, all the tests pass on Chrome and Firefox, but they fail on Safari. Pasting the error below:
Chrome 58.0.3029 (Mac OS X 10.12.4): Executed 704 of 704 SUCCESS (26.366 secs / 22.716 secs) Firefox 53.0.0 (Mac OS X 10.12.0): Executed 667 of 667 SUCCESS (23.917 secs / 22.596 secs) Safari 10.1.0 (Mac OS X 10.12.4) ERROR TypeError: First argument must be a string, Buffer, ArrayBuffer, Array, or array-like object. at test/harness/test.js:20219 Chrome 58.0.3029 (Mac OS X 10.12.4): Executed 704 of 704 SUCCESS (26.366 secs / 22.716 secs) Firefox 53.0.0 (Mac OS X 10.12.0): Executed 667 of 667 SUCCESS (23.917 secs / 22.596 secs) npm ERR! code ELIFECYCLE npm ERR! errno 1 npm ERR! browserfs@1.3.0 test:karma: karma start karma.config.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the browserfs@1.3.0 test:karma script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR! /Users/nidhi/.npm/_logs/2017-06-02T21_29_25_594Z-debug.log
ERROR: "test:karma" exited with 1.`

@jvilk
Copy link
Owner

jvilk commented Jul 23, 2017

I opened a bug on the buffer package, which causes this error.

I don't have a good workaround right now.

@jvilk jvilk added the bug label Jul 23, 2017
@jvilk
Copy link
Owner

jvilk commented Jul 23, 2017

Note that this is only a problem in our test environment. Users may encounter this when using the buffer package or BrowserFS within an iframe in Safari.

jvilk pushed a commit that referenced this issue Aug 5, 2017
@jvilk jvilk closed this as completed Aug 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants