Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to display support up to Python 3.12 and Django 5.0? #539

Open
wgordon17 opened this issue Mar 23, 2024 · 3 comments 路 May be fixed by #540
Open

Update docs to display support up to Python 3.12 and Django 5.0? #539

wgordon17 opened this issue Mar 23, 2024 · 3 comments 路 May be fixed by #540

Comments

@wgordon17
Copy link

Hey all (and @justquick), I've been doing some local work on django-activity-stream because I honestly didn't trust the doc's assertion that this is only supported up to Python 3.9 and Django 4.1 馃槄

I've managed to get tox and pytest passing for all environments now (a few minor tweaks to the tox.ini) with the exception of this specific text for Django 5.0. Commenting out that line allows for the rest of the tests to succeed with Django 5.0, and I've opened a thread in the Django Discord to see if there was an undocumented breaking change here that causes the translated text to no longer be stored in the database as LANGUAGE_CODE.

Once I get that sorted, do you have any concerns with me submitted a PR with the updated tox.ini changes, any changes I might need to do to resolve that specific test, and a docs update to reflect the changed support?

@wgordon17
Copy link
Author

Alrighty, problem identified, https://forum.djangoproject.com/t/new-5-0-behavior-storing-translated-string-in-database-solved/29483/5, and a PR is on it's way. Thankfully, this repo supports all the way up to 3.12 without any changes, but just needs a minor change to account for changes in Django 5.0 馃帀

@wgordon17 wgordon17 linked a pull request Mar 26, 2024 that will close this issue
@simkimsia
Copy link

Just wanted to add that the docs don't seem to be updated as well. https://django-activity-stream.readthedocs.io/en/latest/changelog.html

Is this supporting Django 4.2?

@wgordon17
Copy link
Author

@simkimsia, I'm not the repo owner, but I did successfully run all the tests for this package on Django 4.2, all the way up through Python 3.12. There's a very minor change needed in order for the package to have the same support in Django 5+ that it has in the lower versions, the only implication of not having this fix is that translated strings get stored in the DB as translated, instead of the current functionality which is storing untranslated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants