Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django Sites usage with single-site projects #408

Open
moorchegue opened this issue Oct 1, 2018 · 5 comments
Open

Django Sites usage with single-site projects #408

moorchegue opened this issue Oct 1, 2018 · 5 comments
Labels
future planned future features

Comments

@moorchegue
Copy link

Hi there! I'm considering using django-activity-stream for my project, it seems to fit perfetcly except one little hiccup — Django Sites framework requirement.

I noticed that django.contrib.sites is only being used in a couple of feed view methods. Would it be possible to only require Sites for projects that do have multiple sites (i.e. already have Sites installed) and for simpler projects use domain information from the request?

@moorchegue
Copy link
Author

Also for the multiple-site projects there're alternative approaches (e.g. http://niwinz.github.io/django-sites/latest/) and it would be nice to not have to use a single package but have some flexibility. Although this is not my problem currently, just a thought.

@moorchegue
Copy link
Author

I guess that's a no then 😄

@justquick
Copy link
Owner

Oops closed by mistake

@justquick justquick reopened this Feb 20, 2022
@justquick justquick added the future planned future features label Feb 20, 2022
@glibersat
Copy link

Hi!

I'm also interested in this feature. @justquick, would you be open to a PR?

Thanks,

Guillaume

@justquick
Copy link
Owner

yes please PR any ideas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
future planned future features
Projects
None yet
Development

No branches or pull requests

3 participants