CI fails when using version 'a7683763fa44598d9faf6157a27632def618ad42'

[bcmhercun]

I'm aware that 'a7683763fa44598d9faf6157a27632def618ad42' version is not a release but I wanted to update my pipeline to get rid of Node.js 16 deprecation warning.

Maybe someone (@jurplel ) is aware of this issue already but I'm leaving it here just in case.

[pzhlkj6612]

Hi.

You can build this action yourself. This is how CI does it:

install-qt-action/.github/workflows/test.yml

Lines 91 to 116 in a768376

	steps:
	- uses: actions/checkout@v4
	- uses: actions/setup-node@v4
	with:
	node-version: 20
	cache: npm
	cache-dependency-path: action/
	- run: |
	cd action
	npm ci || npm install
	shell: bash
	- run: |
	cd action
	npm run build
	- name: Install Qt with options and default aqtversion
	if: ${{ !matrix.aqtversion && matrix.qt.version }}
	uses: ./
	with:
	modules: ${{ matrix.qt.modules }}
	version: ${{ matrix.qt.requested }}
	tools: tools_ifw tools_qtcreator,qt.tools.qtcreator
	cache: ${{ matrix.cache == 'cached' }}

For your purpose:

    steps:
      - uses: actions/checkout@v4
        with:
          repository: 'jurplel/install-qt-action'
          ref: 'a7683763fa44598d9faf6157a27632def618ad42'
          path: 'install-qt-action'

      - uses: actions/setup-node@v4
        with:
          node-version: 20
          cache: npm
          cache-dependency-path: install-qt-action/action/

      - name: Build jurplel/install-qt-action
        run: |
          cd install-qt-action/action/
          npm ci || npm install
          npm run build
        shell: bash

      - name: Install Qt
        uses: install-qt-action/
        with:
          modules: ...
          version: ...
          tools: ...
          cache: ...

Append your own steps then everything should be OK.

[bcmhercun]

@pzhlkj6612

It is not pointing to the line where error is occurring.
I'm assuming it is about
uses: install-qt-action/

EDITED:
uses: ./install-qt-action/action/

fixed the issue (kinda obvious but I missed it at first glance :D

[pzhlkj6612]

I'm assuming it is about uses: install-qt-action/

EDITED: uses: ./install-qt-action/action/

fixed the issue

My bad, you're right.

Does your own built action function normally?

[bcmhercun]

I'm assuming it is about uses: install-qt-action/
EDITED: uses: ./install-qt-action/action/
fixed the issue

My bad, you're right.

Does your own built action function normally?

@pzhlkj6612 Yes, after this change in uses: it works well ;)

[bcmhercun]

@pzhlkj6612 unfortunately another deprecation warning has occured:

In this step:

    - name: Install Qt
      uses: ./install-qt-action/action/
      with:
        version: 6.2.4
        dir: ${{ env.QT_INSTALL_DIR }}
        cache: true

There's no direct call to set-output. Does anybody have idea how to trace it?

[Wissididom]

@pzhlkj6612 unfortunately another deprecation warning has occured:

In this step:

    - name: Install Qt
      uses: ./install-qt-action/action/
      with:
        version: 6.2.4
        dir: ${{ env.QT_INSTALL_DIR }}
        cache: true

There's no direct call to set-output. Does anybody have idea how to trace it?

For that I think this repos just needs to update @actions/core to at least 1.10.0 (See https://github.com/jurplel/install-qt-action/blob/master/action/package.json and https://github.com/actions/toolkit/blob/main/packages/core/RELEASES.md) - Preferable 1.10.1 since that currently is latest

[pzhlkj6612]

For that I think this repos just needs to update @actions/core to at least 1.10.0 (See https://github.com/jurplel/install-qt-action/blob/master/action/package.json and https://github.com/actions/toolkit/blob/main/packages/core/RELEASES.md) - Preferable 1.10.1 since that currently is latest

@Wissididom , I think you are right.

install-qt-action/action/package.json

Line 20 in a768376

"@actions/core": "^1.9.1",

1.10.0

• saveState and setOutput now use environment files if available #1178
• getMultilineInput now correctly trims whitespace by default #1185

https://github.com/actions/toolkit/blob/415c42d27ca2a24f3801dd9406344aaea00b7866/packages/core/RELEASES.md#1100

@jurplel maybe we need to update the dependency.

[jurplel]

I'll make a release

[jurplel]

I am having some test failures on the v3 branch. I need to find time to debug it before I can make a release

[bcmhercun]

@jurplel this also needs to be updated to 4.0.0

install-qt-action/action/package.json

Line 19 in 74ca8cd

"@actions/cache": "^3.0.0",

[Wissididom]

this also needs to be updated to 4.0.0

install-qt-action/action/package.json

Line 19 in 74ca8cd

"@actions/cache": "^3.0.0",

I don't think so. According to https://github.com/actions/toolkit/blob/main/packages/cache/RELEASES.md and https://www.npmjs.com/package/@actions/cache 3.2.4 is the latest version.

I think it needs to be updated to at least 3.0.5 tho since that's what they write in their CHANGELOG.md for that version:

Update `@actions/cache` to use `@actions/core@^1.10.0`

[bcmhercun]

this also needs to be updated to 4.0.0

install-qt-action/action/package.json

Line 19 in 74ca8cd

"@actions/cache": "^3.0.0",

I don't think so. According to https://github.com/actions/toolkit/blob/main/packages/cache/RELEASES.md and https://www.npmjs.com/package/@actions/cache 3.2.4 is the latest version.

I think it needs to be updated to at least 3.0.5 tho since that's what they write in their CHANGELOG.md for that version:

Update `@actions/cache` to use `@actions/core@^1.10.0`

[Wissididom]

this also needs to be updated to 4.0.0

install-qt-action/action/package.json

Line 19 in 74ca8cd

"@actions/cache": "^3.0.0",

I don't think so. According to actions/toolkit@main/packages/cache/RELEASES.md and npmjs.com/package/@actions/cache 3.2.4 is the latest version.
I think it needs to be updated to at least 3.0.5 tho since that's what they write in their CHANGELOG.md for that version:

Update `@actions/cache` to use `@actions/core@^1.10.0`

Then I think I got the Cache Action that is being used as a standalone action and the cache action, that is part of the toolkit to develop actions with, mixed up. On npm was the actions/cache of toolkit (where I started looking) and you linked the actual actions/cache action hosted on GitHub.