New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
target: android failing with v3 #161
Comments
Specifying
|
Yes, you are correct. The offending code is here: install-qt-action/action/src/main.ts Lines 103 to 105 in 2b22cf1
The architecture |
Does it make sense to fall back to android_armv7? |
Good question. I would lean towards using I could be wrong, but I thought that if you鈥檙e trying to put an Android app on the app store, you need to bundle binaries for all architectures into your APK. Maybe the right answer is to install every architecture available? |
I think you need at least 64 bit arches (i know you cannot ship armv7 alone, possibly you can ship arm64 alone). |
On second thought, maybe it would be more appropriate to have the action run There鈥檚 definitely a use case for installing all of the architectures, or a handful of architectures, but it probably should not be the default case. It could be problematic to have the defaults use so much unnecessary net traffic and CPU time. |
How would you choose what to pick? |
This decision tree should give you a usable default value in most cases, without surprising anyone with novel behavior. The one case where it would not work is if the download.qt.io servers are down, in which case this action is not going to work anyway. |
Hmm... I may be missing some historical reasons, but I would be surprised to get armv7 by default. |
For android,
I agree that these behaviors are more intuitive than just choosing |
Good point. |
I think for now I will just check for qt >= 5.14 and have it use |
install-qt-action/action/src/main.ts Line 104 in c8ebe28
I think this is the wrong version comparison. - if (compareVersions(this.version, ">=", "5.14.0")) {
+ if (compareVersions(this.version, ">=", "5.14.0") && compareVersions(this.version, "<", "6.0.0")) { |
fix install problem: jurplel/install-qt-action#161
Oh, I misunderstood! Thank you! |
Likely caused by: 8358dd9#diff-ad2b60fd0fe67776e1dcc7801bcaeed4934823e3103a9d2ae656073002304eb1R115-R117
The following command works in a local test
The text was updated successfully, but these errors were encountered: