Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with pytest 8.1.0 #133

Closed
krassowski opened this issue Mar 4, 2024 · 1 comment
Closed

Not compatible with pytest 8.1.0 #133

krassowski opened this issue Mar 4, 2024 · 1 comment
Labels

Comments

@krassowski
Copy link
Member

pytest 8.1.0 was just released and broke Ci for jupyterlab:

pluggy._manager.PluginValidationError: Plugin 'check-links' for hook 'pytest_collect_file'
hookimpl definition: pytest_collect_file(path: 'Any', parent: 'pytest.Collector') -> 'CheckLinks | None'
Argument(s) {'path'} are declared in the hookimpl but can not be found in the hookspec

jupyterlab/jupyterlab#15908

This is because pytest-dev/pytest#11757 removed the path parameter (there is file_path). It looks like a mistake in the docs saying that path was removed in 8.0 but in fact it was deprecated and had a legacy fallback, which I think is tracked in pytest-dev/pytest#12069

@krassowski krassowski added the bug label Mar 4, 2024
Copy link

welcome bot commented Mar 4, 2024

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant