Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add store ID to page config #74

Merged
merged 1 commit into from Aug 14, 2019
Merged

Add store ID to page config #74

merged 1 commit into from Aug 14, 2019

Conversation

saulshanabrook
Copy link
Member

No description provided.

Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@blink1073
Copy link
Member

@vidartf, any objections?

@vidartf
Copy link
Member

vidartf commented Aug 14, 2019

The concept is good. Its probably (?) ok to put it on the application object.

@saulshanabrook
Copy link
Member Author

Its probably (?) ok to put it on the application object.

I only used it because of a stack overflow response:

Application is the right object to store (semi-)persistent data. However, as suggested on other anwser, you should consider using some kind of database to store this data.

I couldn't find any Tornado docs that mention this use case. Maybe @Zsailer would know?

@Zsailer
Copy link
Member

Zsailer commented Aug 14, 2019

Like @vidartf, I think this is fine. I was trying to find a scenario like this in JupyterHub—thinking there might be some semi-persistent data case there—but was unsuccessful.

Typically, all persistent data storage mechanisms are listed in "setting" of the tornado application and stored somewhere on the server, but if you don't need this data to persist after the server is stopped, this should work. The data should persist with each request...

@blink1073
Copy link
Member

Thanks @vidartf and @Zsailer, let's give this a shot!

@blink1073 blink1073 merged commit 830c166 into master Aug 14, 2019
@blink1073
Copy link
Member

Released as 1.0.2.

@saulshanabrook
Copy link
Member Author

@blink1073 Thank you!

@saulshanabrook saulshanabrook deleted the storeid branch August 14, 2019 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants