Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

References are duplicated in tsconfig.test.json #10830

Merged
merged 1 commit into from Aug 13, 2021
Merged

References are duplicated in tsconfig.test.json #10830

merged 1 commit into from Aug 13, 2021

Conversation

fcollonval
Copy link
Member

References

Fixes #10541

Code changes

N/A

User-facing changes

N/A

Backwards-incompatible changes

N/A

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@fcollonval fcollonval added this to the 4.0 milestone Aug 13, 2021
blink1073
blink1073 approved these changes Aug 13, 2021
View reviewed changes
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fcollonval fcollonval merged commit 5acd730 into jupyterlab:master Aug 13, 2021
@fcollonval fcollonval deleted the fcollonval/issue10541 branch August 13, 2021 12:33
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 10, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees

@fcollonval fcollonval

Labels
maintenance pkg:application pkg:apputils pkg:cells pkg:codeeditor pkg:codemirror pkg:completer pkg:console pkg:csvviewer pkg:debugger pkg:docmanager pkg:docprovider pkg:docregistry pkg:documentsearch pkg:filebrowser pkg:fileeditor pkg:imageviewer pkg:inspector pkg:logconsole pkg:mainmenu pkg:notebook pkg:outputarea pkg:rendermime pkg:services pkg:settingregistry pkg:shared-models pkg:statusbar pkg:terminal pkg:toc pkg:translation pkg:ui-components status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

References are duplicated in tsconfig.test.json
2 participants
@fcollonval @blink1073