Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing break in switch #10829

Merged
merged 1 commit into from Aug 13, 2021
Merged

Fix missing break in switch #10829

merged 1 commit into from Aug 13, 2021

Conversation

fcollonval
Copy link
Member

@fcollonval fcollonval commented Aug 13, 2021

Bug introduced when merging #10632

Bug introduce when merging #10632
@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@fcollonval fcollonval added the bug label Aug 13, 2021
@fcollonval fcollonval added this to the 3.2.x milestone Aug 13, 2021
@fcollonval fcollonval merged commit f52f667 into master Aug 13, 2021
@fcollonval fcollonval deleted the fix/missing-break branch August 13, 2021 07:58
@blink1073
Copy link
Member

@meeseeksdev please backport to 3.2.x

@lumberbot-app
Copy link

lumberbot-app bot commented Sep 23, 2021

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout 3.2.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 f52f6678f35200f2be70dc483d34338291546782
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #10829: Fix missing break in switch'
  1. Push to a named branch :
git push YOURFORK 3.2.x:auto-backport-of-pr-10829-on-3.2.x
  1. Create a PR against branch 3.2.x, I would have named this PR:

"Backport PR #10829 on branch 3.2.x (Fix missing break in switch)"

And apply the correct labels and milestones.

Congratulation you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove Still Needs Manual Backport label once the PR gets merged.

If these instruction are inaccurate, feel free to suggest an improvement.

@blink1073 blink1073 mentioned this pull request Sep 23, 2021
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Mar 24, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug pkg:codemirror status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants