Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Filebrowser Context Menu order #9960

Closed
ianhi opened this issue Mar 19, 2021 · 7 comments
Closed

Improve Filebrowser Context Menu order #9960

ianhi opened this issue Mar 19, 2021 · 7 comments

Comments

@ianhi
Copy link
Contributor

ianhi commented Mar 19, 2021

Problem

The current options for the filebrowser are not always logically grouped. I also think that the order of the current logical groups could be improved.

Currently the order is:

image

Proposed Solution

  1. Move Paste up be near Delete, Cut etc..
  2. Swap Download and Shutdown Kernel
    • Download feels logical to group with with copy shareable link and copy download link
  3. Move the New ___ operations above the link sharing commands. I suspect that the New items are far more fequently used than things like Copy Shareable Link

It might also be nice to visually delineate these logical groupings with a small gray line like is done in the menus from the topbar
image

@ianhi
Copy link
Contributor Author

ianhi commented Mar 19, 2021

Also ideally the Shut Down kernel option would not be in the menu when you click on items that do not support a kernel. Currently it shows up for any file type.

@jtpio
Copy link
Member

jtpio commented Mar 19, 2021

Also ideally the Shut Down kernel option would not be in the menu when you click on items that do not support a kernel. Currently it shows up for any file type.

It might be possible to add the isVisibile field to the corresponding command here to hide the entry depending on the items in the current selection:

commands.addCommand(CommandIDs.shutdown, {
execute: () => {
const widget = tracker.currentWidget;
if (widget) {
return widget.shutdownKernels();
}
},
icon: stopIcon.bindprops({ stylesheet: 'menuItem' }),
label: trans.__('Shut Down Kernel')
});

@jtpio jtpio added this to the Future milestone Mar 19, 2021
@jtpio
Copy link
Member

jtpio commented Nov 1, 2021

@ianhi is this still an issue, now that the context menu has been improved in the latest versions?

image

Also the context menu can now be configured via the settings:

https://jupyterlab.readthedocs.io/en/stable/extension/extension_points.html?#context-menu

Also ideally the Shut Down kernel option would not be in the menu when you click on items that do not support a kernel. Currently it shows up for any file type.

This one is still relevant but could be tracked in a separate issue.

@ianhi
Copy link
Contributor Author

ianhi commented Nov 2, 2021

Much improved!

This one is still relevant but could be tracked in a separate issue.

👍

@ianhi ianhi closed this as completed Nov 2, 2021
@jasongrout
Copy link
Contributor

I also notice Paste is still down at the bottom. It looks like the rationale is that the bottom section is for things that create files, but I do agree that Paste is more typically found up with cut and copy.

@ianhi
Copy link
Contributor Author

ianhi commented Nov 2, 2021

I also notice Paste is still down at the bottom.

ohhh I missed that. I think that was my main concern when opening this issue. (I shouldn't be closing issues after midnight...)

I'll reopen this then, but if it's decided that Paste should stay down there then closing is ok with me

@ianhi ianhi reopened this Nov 2, 2021
@fcollonval
Copy link
Member

fcollonval commented Jan 26, 2022

Closing as Paste is next to copy and cut since #10666

image

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants