-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jump to line keyboard shortcut #7704
Comments
Overwriting the Setting does not solve the problem. Does anybody know a workaround? |
This comes from the CodeMirror jump-to-line extension we load: https://github.com/codemirror/CodeMirror/blob/b9e6190b3edf16fe959055c45807e06f833f9d1f/addon/search/jump-to-line.js#L52 I don't have a keyboard where Alt G prints a key, but a workaround might be to define a keyboard shortcut in {
shortcuts: [
{
command: 'apputils:run-first-enabled',
selector: 'body',
keys: [
'Alt G',
],
args: {
commands: [
'console:replace-selection',
'fileeditor:replace-selection',
'notebook:replace-selection',
],
args: {
text: '@',
},
},
},
],
} |
@jasongrout Thank you, that works. I wonder if this could be a checkbox somewhere in the settings for users on macOS? |
I think it is not about macOS, but about keyboard layouts in general. One problem here is that some editor keyboard shortcuts do not use the jlab keyboard shortcut system (like this Alt G). Instead, I think we should reimplement these keyboard shortcuts using the jlab keyboard shortcut system if possible. That would make it easy to customize the shortcut. |
Note that this workaround will most likely not work if Alt/AltGr + G is a dead key, which is for instance the case for the ergonomic bepo layout, where it is used to switch to the greek layer (which is surprisingly useful in Unicode-friendly languages like Julia, since it is faster than typing "\alpha" then |
Right, we were trying to solve the problem of Alt+G being the combination to type Or are you saying that in JupyterLab, instead of switching to the greek layer, Alt/AltGr + G is triggering the go to line functionality in CodeMirror? |
Yes, this is what I meant: with my keyboard layout, the "go to line" shortcut from CodeMirror is conflicting with a dead key and prevents access to an entire layer. In principle, I could use your workaround to explicitly redefine all the AltGr/Opt + g + [a-zA-Z], but that would be cumbersome. Sorry if I wasn’t clear. |
This issue has been mentioned on Jupyter Community Forum. There might be relevant details there: https://discourse.jupyter.org/t/unbinding-right-alt-g-from-jupyterlab/12855/2 |
Hi, has there been any progress on this issue? |
In Jupyter Lab 3.4.5 and 3.5.0 I still encounter this issue, but only with Firefox (106.0.5). I have no problem with Brave (1.45.123) or Safari (16.1). I am on macOS 12.6.1 (ARM). |
Still major pain point. For almost 4 years now! Contributes to that fact that the Jupyter Notebook 7 user experience feels extremely frustrating even months after switching from JN 6. |
@krassowski @rofr this looks like a separate issue to me. This issue is about Alt-G specifically, which is not any of the Alt - number keys, and according to the title thus is not fixed by #15761. |
@burnpanck yes, this issue (#7704) is not fixed by #15761, but #15744 (mostly) is. |
Actually #15790 + replacing Alt + G from CM6 binding to a lumino command would also solve this issue. |
I don't know the codebase at all ("CM6 binding" and "lumino command" mean absolutely nothing to me), but if #15790 is able to fix the alt-g issue, that would be great. Just wanted to point out that the alt-g issue does not only appear in the JupyterLab frontend, but also in the "classic notebook" (which is still my favourite interface, despite some severe user-experience step-backs since the change to the JupyterLab backend with version 7). Given that the alt-g key binding seems to live outside of the "normal" JupyterLab shortcuts within the Jupyter notebook, this may or may not be related with that "CM6 binding". |
Description
The keyboard shortcut for the "jump to line" command overwrites one of the keys I use but I cannot find the location where to disable to command/shortcut. I am talking about the command that opens the following window:
It is not listed in
Settings -> Keyboard Shortcuts -> Default Settings
and I did not add/overwrite it in theUser Settings
.Reproduce
On my keyboard:
Alt G
Context
macOS-10.11.6-x86_64-i386-64bit
Google Chrome: Version 79.0.3945.88 (Official Build) (64-bit)
3.8.0 | packaged by conda-forge | (default, Nov 22 2019, 19:11:19) [Clang 9.0.0 (tags/RELEASE_900/final)]
Troubleshoot Output
Command Line Output
Browser Output
The text was updated successfully, but these errors were encountered: