Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing a second shortcut changes the first one in shortcuts editor #16211

Closed
kolibril13 opened this issue Apr 20, 2024 · 3 comments · Fixed by #16214
Closed

Changing a second shortcut changes the first one in shortcuts editor #16211

kolibril13 opened this issue Apr 20, 2024 · 3 comments · Fixed by #16214

Comments

@kolibril13
Copy link

After pip install -U --pre jupyterlab on a Mac, adding a second shortcut does not work:

Screen.Recording.2024-04-20.at.13.30.29.mov

this was first reported in #16186 (comment) and confirmed by @krassowski :

I can reproduce this, it is a bug. I think it deserves its own issue as it is not Mac specific.

@krassowski
Copy link
Member

My comment saying that I can reproduce was on:

changing the second shortcut does not work: it changes the first shortcut instead

There was no mention of adding a second shortcut, just editing. So I will edit the title to reflect it. I assume by shortcuts menu you meant shortcuts editor?

@krassowski krassowski changed the title Adding a second shortcut does not work in the new Shortcuts menu Changing a second shortcut changes the first one in shortcuts editor Apr 20, 2024
@krassowski krassowski added this to the 4.2.0 milestone Apr 20, 2024
@kolibril13
Copy link
Author

yep, thanks for the clarification!

@krassowski
Copy link
Member

@kolibril13 this should be fixed by #16214. Can you test this on Binder and leave a review on the PR? https://mybinder.org/v2/gh/krassowski/jupyterlab/fix-changing-second-default-shortcut?urlpath=lab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants