Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcuts with same command but different arguments amiss in shortcuts UI #15759

Closed
krassowski opened this issue Feb 7, 2024 · 5 comments · Fixed by #16043
Closed

Shortcuts with same command but different arguments amiss in shortcuts UI #15759

krassowski opened this issue Feb 7, 2024 · 5 comments · Fixed by #16043
Assignees
Milestone

Comments

@krassowski
Copy link
Member

Description

Are the 20 different bindings all for one action intended? Or a bug? (If not a bug: why has this behaviour been chosen??). Ok, I see from the json settings and the PR discussion that the different bindings are for selecting different objects in the sidebar — but I’ll note that this isn’t reflected at all in the GUI settings editor.

Originally posted by @defjaf in #15744 (comment)

Reproduce

  1. Open "Settings Editor"
  2. Choose "Keyboard shortcuts"
  3. See that all 20 keybindings for "Show Left Activity Bar" are shown as a single shortcut, even though each of these has a different set of arguments
  4. See that you cannot modify these shortcuts (edits are not saved)

image

Expected behavior

  1. Shortcuts with different arguments are displayed separately
  2. Shortcuts with different arguments can be modified independently
  3. The arguments are displayed or even modifiable from shortcuts UI

Context

  • JupyterLab version: 4.1.0 but also affects other shortcuts with arguments in 4.0.x and possibly older
@defjaf
Copy link

defjaf commented Feb 7, 2024

(Thanks for translating my comment to a proper issue!)

@Lawiss
Copy link

Lawiss commented Feb 8, 2024

It's annoying as the shortcut prevents me to type [ when I hit Maj+Option+5, it toggles the left Activity Bar instead.
I'm on jupyterlab version 4.1.0, python 3.11.5, MacOS 14.2.1.

@JasonWeill
Copy link
Contributor

@Lawiss Which keyboard are you using? The issue with the [ shortcut on an Italian keyboard was reported in #15744.

@JasonWeill JasonWeill removed the status:Needs Triage Applied to new issues that need triage label Feb 13, 2024
@Lawiss
Copy link

Lawiss commented Feb 13, 2024

I use the French AZERTY (numerical) keyboard, I think this is the same issue than in #15744.

@Lawiss
Copy link

Lawiss commented Feb 14, 2024

I tested with release 4.1.1 and the problem seems solved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants