Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to CSS Custom Highlight API for search results #15333

Open
krassowski opened this issue Nov 1, 2023 · 1 comment
Open

Migrate to CSS Custom Highlight API for search results #15333

krassowski opened this issue Nov 1, 2023 · 1 comment

Comments

@krassowski
Copy link
Member

Problem

JupyterLab highlights search matches in code and outputs by modifying the DOM. This is:

Proposed Solution

CSS Custom Highlight API is the preferred way of achieving highlighting of results; there is a dedicated example on MDN.

Additional context

As of the day of writing the browser support is not yet there, but Firefox Nightly recently enabled it so it will likely ship.

  • Chrome: 102+
  • Edge: 102+
  • Firefox: Nightly
  • Opera: 91
  • Safari: nope
@krassowski
Copy link
Member Author

Safari supports this API since 17.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants