Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix minor typo in urls.rst #13902

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Fix minor typo in urls.rst #13902

merged 1 commit into from
Feb 2, 2023

Conversation

chbrandt
Copy link
Contributor

@chbrandt chbrandt commented Feb 1, 2023

Fix a small typo in the last sentence.

@welcome
Copy link

welcome bot commented Feb 1, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@JasonWeill JasonWeill added this to the 3.6.x milestone Feb 1, 2023
JasonWeill
JasonWeill previously approved these changes Feb 1, 2023
View reviewed changes
@fcollonval fcollonval changed the base branch from 3.6.x to master February 2, 2023 08:38
@fcollonval fcollonval dismissed JasonWeill’s stale review February 2, 2023 08:38

The base branch was changed.

@chbrandt @fcollonval
Update urls.rst
47b3d9e 
Fix a small typo in the last sentence.
fcollonval
fcollonval approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chbrandt

I retargeted your branch to master as our process is to always target the default branch and then backport to older versions required fixes.

@fcollonval fcollonval merged commit 786274d into jupyterlab:master Feb 2, 2023
@welcome
Copy link

welcome bot commented Feb 2, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@fcollonval
Copy link
Member

@meeseeksdev please backport to 3.6.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Feb 2, 2023
@chbrandt @meeseeksmachine
Backport PR jupyterlab#13902: Fix minor typo in urls.rst
87e7376
@meeseeksmachine meeseeksmachine mentioned this pull request Feb 2, 2023
Merged
fcollonval pushed a commit that referenced this pull request Feb 2, 2023
@meeseeksmachine @chbrandt
Backport PR #13902: Fix minor typo in urls.rst (#13908)
5eb46f6 
Co-authored-by: Carlos H Brandt <carloshenriquebrandt@gmail.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fcollonval fcollonval fcollonval approved these changes

@JasonWeill JasonWeill JasonWeill left review comments

Assignees

@chbrandt chbrandt

Labels
documentation
Projects
None yet
Milestone
3.6.x
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chbrandt @fcollonval @JasonWeill