-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define colour and background for filebrowser edit field #13895
Define colour and background for filebrowser edit field #13895
Conversation
Thanks for making a pull request to jupyterlab! |
@facusapienza21 would you mind testing on binder (https://mybinder.org/v2/gh/krassowski/jupyterlab/fix-contrast-file-rename?urlpath=lab) to see if the proposed change fixes the problem for you and that it works acceptably in both light and dark theme? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, at least from binder testing it fixes the problem as I was seeing it. Many thanks!
BTW, this should go into both the 3.5 and 3.6 branches - right now 3.5 is super annoying to use in light mode b/c of this problem (at least for all our students, which is a lot of people :) |
The solution in the Binder link works for me too. |
Merging this and backporting for potential inclusion in 3.6.0 (otherwise it will go into 3.6.1), CC @fcollonval. @meeseeksdev please backport to 3.6.x |
…owser edit field
@meeseeksdev please backport to 3.5.x |
…owser edit field
… field (#13899) Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
… field (#13901) Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
Fantastic, huge thanks @krassowski and our wonderful bot :) |
References
Fixes #13894
Code changes
Defines a colour to prevent system
input
colour from interfering.User-facing changes
No changes in light theme. In dark theme:
Backwards-incompatible changes
None