Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define colour and background for filebrowser edit field #13895

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

krassowski
Copy link
Member

References

Fixes #13894

Code changes

Defines a colour to prevent system input colour from interfering.

User-facing changes

No changes in light theme. In dark theme:

Before After
Screenshot from 2023-01-30 23-45-48 Screenshot from 2023-01-30 23-46-16

Backwards-incompatible changes

None

@krassowski krassowski added the bug label Jan 30, 2023
@krassowski krassowski added this to the 3.6.x milestone Jan 30, 2023
@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@github-actions github-actions bot added Design System CSS pkg:filebrowser tag:CSS For general CSS related issues and pecadilloes labels Jan 30, 2023
@krassowski
Copy link
Member Author

@facusapienza21 would you mind testing on binder (https://mybinder.org/v2/gh/krassowski/jupyterlab/fix-contrast-file-rename?urlpath=lab) to see if the proposed change fixes the problem for you and that it works acceptably in both light and dark theme?

Copy link
Contributor

@fperez fperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, at least from binder testing it fixes the problem as I was seeing it. Many thanks!

@fperez
Copy link
Contributor

fperez commented Jan 31, 2023

BTW, this should go into both the 3.5 and 3.6 branches - right now 3.5 is super annoying to use in light mode b/c of this problem (at least for all our students, which is a lot of people :)

@facusapienza21
Copy link

The solution in the Binder link works for me too.

@krassowski
Copy link
Member Author

Merging this and backporting for potential inclusion in 3.6.0 (otherwise it will go into 3.6.1), CC @fcollonval.

@meeseeksdev please backport to 3.6.x

@krassowski krassowski merged commit 794d675 into jupyterlab:master Feb 1, 2023
meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Feb 1, 2023
@krassowski
Copy link
Member Author

@meeseeksdev please backport to 3.5.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Feb 1, 2023
fcollonval pushed a commit that referenced this pull request Feb 2, 2023
… field (#13899)

Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
fcollonval pushed a commit that referenced this pull request Feb 2, 2023
… field (#13901)

Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
@fperez
Copy link
Contributor

fperez commented Feb 2, 2023

Fantastic, huge thanks @krassowski and our wonderful bot :)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Design System CSS pkg:filebrowser tag:CSS For general CSS related issues and pecadilloes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected text color in file browser when using light theme
3 participants