Restore partial border effect for menu #13878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cherry-picked from 18c3af7
|
Thanks for making a pull request to jupyterlab! |
github-actions
bot
added
Design System CSS
pkg:application
tag:CSS
|
bot please update snapshots |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixer partial border styling of menu with menubar on 3.6.x reported in #13870
cherry-picked from 18c3af7
Code changes
This is a simple as switching from
transformtotop(the version for 4.x also requires strict containment relaxation, but we don't have containment on all size- managed widgets in 3.x so it does not apply to the backport)User-facing changes
Before vs after:
Backwards-incompatible changes
None