Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic commands are missing in shortcut editor #13705

Open
krassowski opened this issue Jan 3, 2023 · 6 comments · May be fixed by #14015
Open

Semantic commands are missing in shortcut editor #13705

krassowski opened this issue Jan 3, 2023 · 6 comments · May be fixed by #14015
Assignees
Labels
bug pkg:settingeditor tag:Regression Behavior that had been broken, was fixed, and is broken again tag:Settings
Milestone

Comments

@krassowski
Copy link
Member

Description

Semantic commands (#11386, e.g. "Restart and run all cells", runmenu:restart-and-run-all) are missing in Setting Editor's Shortcuts section:

This might be related to #11898.

Reproduce

Screenshot from 2023-01-03 19-27-27

Expected behavior

  1. Shortcuts are searched by all: label, caption and command ID
  2. Semantic commands have proper labels and captions

Context

  • JupyterLab version: 3.x and 4.0.0alpha
@krassowski krassowski added bug status:Needs Triage Applied to new issues that need triage labels Jan 3, 2023
@fcollonval fcollonval added this to the 4.0.0 milestone Jan 4, 2023
@fcollonval
Copy link
Member

fcollonval commented Jan 4, 2023

Do you see the bug in 3.x too? If so, the bug may not be related to Semantic command as that feature was not backported (due to the induced api change).

@krassowski
Copy link
Member Author

I see it on both 3.5 and master. Maybe was introduced by #10469? But then I don't know why it is also seen on 4.0.

@JasonWeill
Copy link
Contributor

I can also repro with master

@JasonWeill JasonWeill added tag:Settings pkg:settingeditor and removed status:Needs Triage Applied to new issues that need triage labels Jan 5, 2023
@JasonWeill JasonWeill added the tag:Regression Behavior that had been broken, was fixed, and is broken again label Jan 24, 2023
@JasonWeill JasonWeill modified the milestones: 4.0.0, 4.1.0 Feb 1, 2023
@fcollonval fcollonval modified the milestones: 4.1.0, 4.0.0 Feb 2, 2023
@fcollonval
Copy link
Member

Looking into this, actually this concerns all commands that do not have an existing shortcuts. The shortcut editors does not get the list of commands but the shortcuts settings.

Fun fact the list of all commands is built to set the description of the JSON schema that is displayed in the JSON Settings editor.

@fcollonval fcollonval self-assigned this Feb 15, 2023
@fcollonval fcollonval linked a pull request Feb 15, 2023 that will close this issue
@fcollonval
Copy link
Member

Adding the list of commands without shortcuts is easy. But the trouble is that they don't have selectors. So the UI must be extended to allow for a selector to be defined; may be we could define a default selector (function of the command category (?)).

@krassowski
Copy link
Member Author

krassowski commented Feb 15, 2023

Looking into this, actually this concerns all commands that do not have an existing shortcuts

Thanks for looking into it futher!

may be we could define a default selector (function of the command category (?)

or just go with "body" and advise users to change it as needed?

@jtpio jtpio modified the milestones: 4.0.0, 4.0.x May 15, 2023
@krassowski krassowski changed the title Semantic commands are missing in shortcut editor (regression) Semantic commands are missing in shortcut editor Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug pkg:settingeditor tag:Regression Behavior that had been broken, was fixed, and is broken again tag:Settings
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants