Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the non-null assertion on IDebugger.ISources #10975

Closed
fcollonval opened this issue Aug 31, 2021 · 0 comments · Fixed by #10976
Closed

Remove the non-null assertion on IDebugger.ISources #10975

fcollonval opened this issue Aug 31, 2021 · 0 comments · Fixed by #10976
Assignees
@fcollonval
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.

Comments

@fcollonval
Copy link
Member

A follow-up for this could be to try to remove the non-null assertion, since IDebugger.ISources might not be available.

Originally posted by @jtpio in #10462 (comment)
@fcollonval fcollonval self-assigned this Aug 31, 2021
fcollonval added a commit to fcollonval/jupyterlab that referenced this issue Aug 31, 2021
@fcollonval
Remove the non-null assertion on IDebugger.ISources
7ffde0b 
Fixes jupyterlab#10975
@fcollonval fcollonval mentioned this issue Aug 31, 2021
Merged
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 28, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@fcollonval fcollonval

Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the non-null assertion on IDebugger.ISources fcollonval/jupyterlab
1 participant
@fcollonval