Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid schema definition duplication in settings #10601

Open
fcollonval opened this issue Jul 11, 2021 · 0 comments
Open

Avoid schema definition duplication in settings #10601

fcollonval opened this issue Jul 11, 2021 · 0 comments

Comments

@fcollonval
Copy link
Member

fcollonval commented Jul 11, 2021

With the introduction of menus and toolbars customization through settings, the schema definition tends to be duplicated in multiple extensions

=> I wonder if we could publish our own types under some URL to avoid repeating this. It might make updating to new versions easier as well.

Originally posted by @krassowski in #10469 (comment)

@fcollonval

Indeed this would be nice. The true source should probably the settings schema. Do you know how and where to publish such schema ?

@krassowski

One option would be https://www.schemastore.org/json/ (I think they would accept one or two shema files for JupyterLab but we should not be publishing too many files there). Another potential option would be to publish it on jupyter.org which might be more reliable long-term but would need a few people to agree (and more work). For proof-of-concept I would start by linking to one of the settings schema on GitHub (via raw.githubusercontent.com or similar to get the raw file) and see if the references work.

Edit: I never did it before, but I believe it is technically possible. I may be wrong though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants