Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Shutdown Error in Test App #10240

Merged
merged 1 commit into from May 13, 2021
Merged

Fix Shutdown Error in Test App #10240

merged 1 commit into from May 13, 2021

Conversation

afshin
Copy link
Member

@afshin afshin commented May 13, 2021

References

Fixes recent CI failures

Code changes

Handle OS error when removing temporary directory.

User-facing changes

None

Backwards-incompatible changes

None

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@blink1073 blink1073 added this to the 3.1 milestone May 13, 2021
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 6df8b18 into jupyterlab:master May 13, 2021
@blink1073 blink1073 deleted the test-env-fix branch May 13, 2021 16:05
@blink1073
Copy link
Member

@meeseeksdev please backport to 3.0.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request May 18, 2021
blink1073 pushed a commit that referenced this pull request May 18, 2021
Co-authored-by: Afshin Taylor Darian <git@darian.af>
cameron-toy pushed a commit to cameron-toy/jupyterlab that referenced this pull request May 28, 2021
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Nov 15, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintenance status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants