Workaround Chromium issue with iframe reload/href

[krassowski]

References

Fixes #10121

Code changes

Remove reload iframe logic. For the original reason for re-loading see: #3399. The tests with modern browsers indicate that it is no longer necessary (and leads to issues with SVG files in Chrome).

User-facing changes

Backwards-incompatible changes

[jupyterlab-dev-mode]

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link:

[krassowski]

Should not break:

from IPython.display import display_svg, SVG
display_svg(SVG(url='http://upload.wikimedia.org/wikipedia/en/a/a4/Flag_of_the_United_States.svg'), metadata=dict(isolated=True))

Should fix:

from IPython.display import HTML
content = HTML("""<a>hi</a>""")
display(content, metadata={'isolated': True})

[krassowski]

It always evaluates to false as it seems though.

[agoose77]

Thanks @krassowski, great work.

Would you mind modifying the PR description to reflect the new fix; i.e.

Remove iframe reload logic

or something?

Otherwise, if this can't be reproduced on any modern browsers then it might be fine? I'm a bit concerned about causing a regression in slightly older clients, but I don't know what our policy on that is, so I defer to those that who do!

[krassowski]

Would you mind modifying the PR description to reflect the new fix; i.e.

Updated.

Otherwise, if this can't be reproduced on any modern browsers then it might be fine? I'm a bit concerned about causing a regression in slightly older clients, but I don't know what our policy on that is, so I defer to those that who do!

Yes, it is a tricky problem. I do not know for certain whether the reload was ever strictly necessary as the old PR that introduced it was not atomic (it included other changes too). Though it is probably more important to have a working implementation on current (=secure) browsers rather than stick to what only worked for the old ones.

Edit: But of course if we get a confirmation that it breaks a relatively recent version of a browser that is still in the LTS then we can add a condition on the version of that browser.

[agoose77]

Perhaps that is the solution then; potentially break for some users, and patch their browsers as required!

[krassowski]

@blink1073 sorry for fussing about it, but it would be really great to have it backported to 3.0.x at some point, as I am now stuck without convenient way of generating SVG plots - which is a pain for my day job. Can I help in any way to move it forward?

[blink1073]

You caught me just in time, I'll work this into releases today.

[blink1073]

@meeseeksdev please backport to 3.0.x

[krassowski]

Thanks!