-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full Low Vision Support (400% zoom) (Mobile/Tablet-Responsive Support) #10004
Comments
Summary (added per request): JupyterLab needs to support zooming in UI and open documents up to 400% without losing information out of the window or requiring horizontal scroll bars. There are two strategies we could keep in mind to solve this: 1) prioritizing the document and keeping it in focus at all zoom levels 2) prioritizing the UI and scaling back the document to make room for it. Please provide feedback on what you think we could do! To my knowledge, JupyterLab's browser zoom situation hasn't changed since this issue was posted. The above comment and #9399 provide great context. For a more recent review scoped only for zoom, you can also visit @steff456's aggregate review issue to see in detail how this is still a problem in JupyterLab now. Possible solutionsWhile the above comment lists what is needed, I'm going to give some proposals of how that might work on a high-level for the different UI regions. These proposals are two extremes; I personally expect we'll end up somewhere in the middle, but I think this is the best place to start discussing since it could include several impactful UX changes. Document emphasis (option 1)In this approach, when screen space is limited—whether because of high browser zoom or a small window—the document area becomes the primary focus. Everything else is able to be accessed, but not all the standard UI is immediately visible. Screen.Recording.2022-09-28.at.5.00.59.PM.movThe major changes:
UI emphasis (option 2)In this approach, when screen space is limited the UI takes most of the space. The document is prominent as possible, but UI takes precedence and must be collapsed by default. This is essentially the current JupyterLab behavior at all zoom levels, but optimized to fix bugs and make the interactions more intentional. Screen.Recording.2022-10-12.at.7.25.40.PM.movThe major changes:
Additional contextThere are many details to work out area by area once we agree on the general approach. I still think we need to agree on this high-level direction first because it could change how we need to solve these problems. Feedback is not only welcome, but desired! I'd like to get fixing this. To get conversation going, you can ask yourself
|
I’ve been asking for feedback across a few meetings in the community calendar and I want to summarize some of what I’m hearing. I hope this helps people who aren’t at these meetings join the conversation. Comments include:
As far as I’ve heard, there’s no clear next step we want to take or direction that has more support. I’m not sure how we want to move forward at the moment, but I will continue to follow up. |
An important data point is Microsoft Word Office 365 (which is the Word version running in the browser). It responds to zoom:
When UI is zoomed it collapses more and more items progressively but does not change the overall layout (statusbar/Ribbon/menu stay where they were to begin with). This seems clever and works exactly as I would expect. |
Summary: Let's informally vote on which of the above directions we want to pursue so we can move this issue forward into fixes! Based on discussions in this issue and this week’s JupyterLab meeting, we’re going to take an informal poll on this issue to figure out which direction to pursue reflow/zoom fixes for. If there’s any objection, this can become a formal JupyterLab Council vote. So far, little concern has been expressed and I’d like to start fixing this issue in earnest. React to this comment with the following to vote:
I will tally the reactions and comment below after midnight Monday Nov 21 Anywhere on Earth unless there are any objections. As always, I’m happy to answer any questions you might have! I believe any of these directions can give help us resolve this issue accessibly. |
Another comment: I often use zoom at ~150% when using 4k screen as I prefer that over increasing fractional scaling desktop environment-wise. It is not clear to me at which point the proposed change to the UI layout from option 1 would be triggered, but I would prefer it to be based on the available space rather than zoom alone (or both, e.g. condition like |
Sorry for the delay, since this was a tie at the deadline, I'm going to tiebreak. While options 1 and 3 have traits I think could make strong interactions for zoom behaviors, the resources we have to make these fixes throughout the UI make me think option 2 (UI emphasis) is the best step for now. This involves mostly fixing existing behaviors rather than working on an entirely new experience. |
Purpose: Fully support all users with a low vision disability on JupyterLab
Screenshots for points 1-4 below: https://imgur.com/a/OStTXXr
Derivative from: #9399
Required Skills: Purely CSS (my guess)
Todo
All sites needs to have the capability to zoom to 200% for WCAG2.0 compliance (~Tablet support), or 400% zoom for WCAG2.1 compliance (~Mobile support) WITHOUT causing anything but vertical scroll bars to appear. The goal of this ticket is to support 400% zoom. If we're gonna do it, let's do it all the way.
overflow: hidden
somewhere)a.) When panel is open on 400%+ zoom, it needs to either be full width and collapse the opposite side's panel and also find a way to collapse the notebook region (middle/main panel) (screenshot on the imgur link of both options)
OR
b.) the side bars need to become overlaps (think how dropdowns work) and then need to drop a background color over everything else that makes it a transparent dark gray color where nothing in the dark gray area is clickable until the panel is closed (screenshot on the imgur link of both options). Only thing missing is notebook underneath it would be the full 100% width of the page (minus the sidebars of course).
position: fixed
in CSS will let you affix something in one place so it remains on scroll.OPTIONAL: One header dropdown causes a subdropdown to appear. Make sure that one looks appropriate. Technically doesn't need to be done to support these things but will look tacky if it's not done. Just needs to open below the tab in the header, not above pretty much.
Not Included
The text was updated successfully, but these errors were encountered: