Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

Improve Image Diff viewer in result report #65

Closed
mbektas opened this issue Jun 20, 2021 · 4 comments
Closed

Improve Image Diff viewer in result report #65

mbektas opened this issue Jun 20, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@mbektas
Copy link
Member

mbektas commented Jun 20, 2021

Support for side-by-side view, swipe and transition like GitHub PR image diff would be great

@mbektas mbektas added the enhancement New feature or request label Jun 20, 2021
@fcollonval fcollonval mentioned this issue Aug 30, 2021
3 tasks
@jtpio
Copy link
Member

jtpio commented Aug 31, 2021

With jupyterlab/jupyterlab#10796 and #81 Galata is now producing a Playwright HTML report directly.

@mbektas Would you like to report this issue as a feature request on the upstream Playwright repo?

@fcollonval
Copy link
Member

A candidate for that could be: https://www.npmjs.com/package/react-image-diff

@mbektas
Copy link
Member Author

mbektas commented Sep 1, 2021

thanks @jtpio and @fcollonval, let me research how Playwright reports work and we can consider an enhancement built into that. I will close this issue for now.

@mbektas mbektas closed this as completed Sep 1, 2021
@fcollonval
Copy link
Member

FYI
The html report web page of Playwright are defined there: https://github.com/microsoft/playwright/tree/master/src/web/htmlReport
The HTML Reporter is defined there: https://github.com/microsoft/playwright/blob/master/src/test/reporters/html.ts

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants