Use of pre-commit

[blink1073]

Description

I added the https://pre-commit.ci/ GitHub App to the org. By default this means that any repo with a .pre-commit-config.yaml file will get a weekly PR to update the versions used. This will help us keep them up to date easier.

cf jupyterlab/jupyterlab#12272

[fcollonval]

This turns CI to red when pre-commit is not configured for example for jupyterlab/pull-request: https://results.pre-commit.ci/run/github/198751265/1648550407.f6iK8ik0SG-Ao664S91hLg

Would it be possible to turn it on only on jupyterlab? and maybe on jupyterlab_server?

I'll raise the question at weekly call.

[blink1073]

Oh bummer, I thought it would just not run if the file wasn't there. Sure, I'll update to scope it to those two repos.

[blink1073]

Done!

[blink1073]

For those with access, the settings are at: https://github.com/organizations/jupyterlab/settings/installations/24508674

[jtpio]

Is there a way to re-run the checks?

Looks like it fails on the latest commit on master:

• jupyterlab/jupyterlab@fa7578e
• https://results.pre-commit.ci/run/github/60374819/1648556934.JUoSwSjVQq-DJygt-mo0nw

Not sure if it's a real failure or just need to be kicked.

[blink1073]

It seems like the jsonschema download can't work on the service, we probably need to skip it.

[blink1073]

cf jupyter-server/jupyter_server#766

[blink1073]

I removed it from JupyterLab as well, because we don't have access to pypi or npm to download the files needed to run the local hooks.

What could be done instead is to use the official mirrors for prettier and eslint. Since there is isn't an official mirror for stylelint, that could be run in GitHub actions only. So the skip config would look like:

ci:
  skip: [check-jsonschema, stylelint, eslint]

That would involve trying to de-conflict what is currently part of the top level package.json including dependencies. I think what would happen is that the versions of the plugins would need to be included in the eslint config, and a separate job for eslint:check:typed would need to be run as a manual hook, which wouldn't run on pre-commit.ci either. So this all seems like a lot of work for the autoupdate feature...

[blink1073]

Ha, another, less-hacky idea is to skip all of the local checks on pre-commit.ci.

[fcollonval]

@blink1073 could we consider this as resolved?

[blink1073]

Sounds good