Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update snapshots does not work out of the box #70

Closed
krassowski opened this issue May 13, 2024 · 1 comment · Fixed by #71
Closed

Update snapshots does not work out of the box #70

krassowski opened this issue May 13, 2024 · 1 comment · Fixed by #71
Labels
bug Something isn't working

Comments

@krassowski
Copy link
Member

Description

The update snapshots job fails in the step using jupyterlab/maintainer-tools/.github/actions/update-snapshots@v1 action with:

Run yarn install
yarn install v1.22.22
// omitted
Run yarn run test:update
yarn run v1.22.22
$ jlpm playwright test --update-snapshots
Internal Error: jupyterlab-my-extension-ui-tests@workspace:.: This package doesn't seem to be present in your lockfile; run "yarn install" to update the lockfile

Note that yarn in the image is now pointing to a very old version of yarn.

Changing npm_client to jlpm by adding an argument in:

extension-template/template/.github/workflows/{% if test %}update-integration-tests.yml{% endif %}

Lines 45 to 50 in b2e180b

- uses: jupyterlab/maintainer-tools/.github/actions/update-snapshots@v1
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
# Playwright knows how to start JupyterLab server
start_server_script: 'null'
test_folder: ui-tests

Fixes the issue for me.

I am not sure if this should be fixed in maintainer-tools by ensuring that yarn berry is used, or here by adding npm_client argument.

Anyone else seen this?
@krassowski krassowski added the bug Something isn't working label May 13, 2024
@fcollonval
Copy link
Member

I haven't use the template in a while. I would go for your fix setting npm_client

@krassowski krassowski mentioned this issue May 14, 2024
Merged
@jtpio jtpio closed this as completed in #71 May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use jlpm as npm_client for snapshot updates jupyterlab/extension-template
2 participants
@krassowski @fcollonval