Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow enable/disable via settings? #24

Closed
3 tasks
asford opened this issue Jan 23, 2021 · 6 comments · Fixed by #32
Closed
3 tasks

Allow enable/disable via settings? #24

asford opened this issue Jan 23, 2021 · 6 comments · Fixed by #32
Labels
enhancement New feature or request

Comments

@asford
Copy link
Contributor

asford commented Jan 23, 2021

This appears to be the de-facto extension for jupyterlab 3.0, at least until jupyterlab/jupyterlab#9068 lands. Would you be open adding settings-support in repo, so that this end-users can (at least) enable/disable the extension?

I would be happy to implement as a PR if you're open.

Work items:

@asford asford changed the title Add settings support? Allow enable/disable via settings? Jan 23, 2021
@axelfahy
Copy link
Collaborator

Sure, you can implement those features if you want. However, it might be duplicated work if the extension lands directly with jupyterlab.

@ianhi
Copy link
Collaborator

ianhi commented Feb 18, 2021

I haven't had time to work on moving it into jlab and unfortunately may not for a while yet. So

  1. If anyone wants to push that work on jlab forward they should feel free to (also welcome to ping me for reviews)
  2. A short term fix for this would make sense
  3. What should probably happen is that jupyterlab-vimrc should be folded into this repo in order to have only a single settings file for all vim related things.

@mlucool
Copy link
Contributor

mlucool commented Mar 29, 2021

This has been implemented in #32

@ianhi ianhi closed this as completed in #32 Apr 29, 2021
ianhi pushed a commit that referenced this issue Apr 29, 2021
@dclong
Copy link

dclong commented May 26, 2021

I thought users can use jupyter server extension enable/disable to enable/disable an extension? However, it seems that the command doesn't work with jupyterlab-vim.

@dclong
Copy link

dclong commented May 26, 2021

Is there a way to disable jupyterlab-vim for all users? I want to install the extension but keep it disabled by default since not all users are familiar with vim keybindings.

@dclong
Copy link

dclong commented May 26, 2021

Never mind. I figured out that the right command to use is jupyter labextension disable @axlair/jupyterlab_vim instead of jupyter labextension disable jupyterlab_vim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants