Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog for 0.10.0 #183

Merged
merged 3 commits into from Jun 9, 2021

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented Jun 9, 2021

@sean-morris @yuvipanda @manics what do you think about cutting 1.0.0? I think we should have 1.0.0 releases of a lot of our old projects instead of sticking around with 0.x.y out of habit.

Questions

  • Is it time to cut a release?
  • Is it time to cut a 1.0.0 release?
  • Is the changelog okay as it is, or do we add something to it?
    Please feel free to push a description or similar to it. I didn't feel well equipped to summarize the changes in this repo since 0.9.0.

@manics
Copy link
Member

manics commented Jun 9, 2021

1.0.0 sounds like a good time to switch master to main? jupyterhub/team-compass#412

@yuvipanda
Copy link
Contributor

I think we should get #177 for 1.0. My gut feel is that it's somewhat involved - the terminal in nbgitpuller is pulled in via hacks on where xterm.js is served from in classic notebook. So let's get a 0.10 out (at least I want one - we have a workshop coming in soon) and then do 1.0 after that?

@consideRatio
Copy link
Member Author

consideRatio commented Jun 9, 2021

@manics I'd support such switch independent on v1.0.0 or not!

@yuvipanda okay! I'll update this to 0.10.0

Note that we have a v1.0 milestone

@consideRatio consideRatio changed the title Add changelog for 1.0.0 Add changelog for 0.10.0 Jun 9, 2021
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Yuvi Panda <yuvipanda@gmail.com>
@yuvipanda
Copy link
Contributor

Note that we have a v1.0 milestone

Not only that, I wrote a blog post for the Jupyter Blog about v1.0 two years ago https://docs.google.com/document/d/1-DULS3KAm8BO2b5lZ14Tmkq46QI5c8pNRGOwqdX3LcE/edit?usp=sharing. Still haven't published it :D

@yuvipanda yuvipanda merged commit 0dc297c into jupyterhub:master Jun 9, 2021
@yuvipanda
Copy link
Contributor

Thanks, @consideRatio! Will this autotag and push to pypi?

@consideRatio
Copy link
Member Author

consideRatio commented Jun 9, 2021

@yuvipanda no autotagging or similar, I just followed the steps in RELEASE.md (manually update version, tag, manually update to dev version, push) and that will make a PyPI release be made.

https://github.com/jupyterhub/nbgitpuller/actions/runs/921152283

Done: https://pypi.org/project/nbgitpuller/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants