Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add section to customizing showing how to use template inheritance #1719

Merged
merged 1 commit into from Mar 10, 2022

Conversation

stefanv
Copy link
Contributor

@stefanv stefanv commented Feb 11, 2022

@SylvainCorlay @choldgraf An update to the docs to illustrate new-style template usage, as suggested :)

@Carreau Since this is based on your original template from https://github.com/Carreau/jupytercontrib

Note: there are still entire sections in the docs that need reviewing for new-style templates, such as https://nbconvert.readthedocs.io/en/latest/external_exporters.html

@stefanv stefanv force-pushed the example-of-template-inheritance branch from 3fc583f to b24eb2d Compare February 11, 2022 08:44
@choldgraf
Copy link
Contributor

@Carreau can you add me as an admin on ReadTheDocs? Or can you enable PR previews?

Copy link
Contributor

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't enable the readthedocs PR previews because I'm not an admin there, but the copy in general looks good to me!

@SylvainCorlay SylvainCorlay merged commit 5d57c16 into jupyter:main Mar 10, 2022
@SylvainCorlay
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants