Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nbconvert_library.ipynb #1695

Merged
merged 1 commit into from Dec 28, 2021
Merged

Update nbconvert_library.ipynb #1695

merged 1 commit into from Dec 28, 2021

Conversation

letterphile
Copy link
Contributor

The generated html file was not following the 'classic' template, but instead 'lab', when I ran the code according to documentaion. But when I passed the template_name as a keyword arguement to HTMLExporter it worked. So I made necessary changes to the code, in a way which worked for me. Please do a review of the code and accept the changes

The generated html file was not following the 'classic' template, but instead 'lab', when I ran the code according to documentaion. But when I passed the template_name as a keyword arguement to HTMLExporter it worked. So I made necessary changes to the code, in a way which worked for me. Please do a review of the code and accept the changes
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073
Copy link
Member

I'm working on the CI failure now as a separate PR (it is unrelated to this change).

@letterphile
Copy link
Contributor Author

okay, no problem

@blink1073 blink1073 closed this Dec 28, 2021
@blink1073 blink1073 reopened this Dec 28, 2021
@blink1073 blink1073 merged commit 45df4b6 into jupyter:main Dec 28, 2021
@blink1073 blink1073 added this to the 6.4 milestone Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants