Fix recent pandoc latex tables by adding calc and array (#1536, #1566) #1686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pandoc >= 2.11.1 requires the calc package, and pandoc >= 2.11.3 requires the array package, for larger tables (taken from git blame for pandoc's templates). This commits adds the two packages in an order similar to that in pandoc's templates.
|
Also fixes #1649. |
|
cc @ivanov you may be more familiar with that part of the code base - wrt pandoc. |
ivanov
approved these changes
Dec 9, 2021
There was a problem hiding this comment.
Thanks for this @cgevans (and @SylvainCorlay for the ping).
This change looks good, jgm/pandoc@bd7c9eb and jgm/pandoc@7c4d7db are the relevant commits on the pandoc side.
I just kicked the tests because one of them failed due to some transient network issue.
This was referenced Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pandoc >= 2.11.1 requires the calc package, and pandoc >= 2.11.3
requires the array package, for larger tables (taken from git blame
for pandoc's templates). This commits adds the two packages in
an order similar to that in pandoc's templates.
This should fix both #1536 and #1566.