Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent page breaks in outputs when printing #1679

Merged
merged 1 commit into from Dec 8, 2021

Conversation

SylvainCorlay
Copy link
Member

@SylvainCorlay SylvainCorlay commented Nov 23, 2021

Alternative to #1676, based on the move from flexbox to table display implemented in jupyterlab/jupyterlab#11508, which passes the visual regression tests.

I think that using table is cleaner than using inline-box which has other side effects (like adding vertical space between lines unless setting the font size to 0).

Closes #1676.

@SylvainCorlay
Copy link
Member Author

This is ready to go, especially as jupyterlab/jupyterlab#11508 is now merged.

@SylvainCorlay SylvainCorlay merged commit e5d0cfd into jupyter:main Dec 8, 2021
@SylvainCorlay SylvainCorlay deleted the no-page-break branch December 8, 2021 13:17
@blink1073 blink1073 added this to the 6.4 milestone Dec 28, 2021
brichet added a commit to brichet/nbconvert that referenced this pull request Jun 26, 2023
brichet added a commit to brichet/nbconvert that referenced this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants