Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameters to client.py and client.js #37

Open
dockter-84 opened this issue Sep 27, 2016 · 2 comments
Open

Add parameters to client.py and client.js #37

dockter-84 opened this issue Sep 27, 2016 · 2 comments

Comments

@dockter-84
Copy link
Contributor

dockter-84 commented Sep 27, 2016

Because there's a "hardcoded" relationship between input parameter, kernel name, and source code file, we are not able to run the python, scala, and R demos on kernels with different kernel names.

Can you add parameters like --kernel-name <kernel_name> and --source <filename> to the client.py and client.js demonstration programs? These parameters would supersede the values in the dictionary within the code.

That way we could run:

node client.js --kernel-name new-scala-version  --source example.scala
@dockter-84
Copy link
Contributor Author

As a work-around, I'm doing this after cloning the repository:

sed -i.$(date +'%s') \
  -e s/"kernelName: 'python'"/"kernelName: 'python2-spark20'"/g \
  -e s/"kernelName: 'scala'"/"kernelName: 'scala-spark20'"/g \
  -e s/"kernelName: 'ir'"/"kernelName: 'r-spark20'"/g \
  ~/kernel_gateway_demos/node_client_example/src/client.js

@parente
Copy link
Member

parente commented Nov 12, 2016

@dockter-84 I'm happy to take a PR here that extends the demo scripts with the kernel-name and source parameters.

/cc @DTAIEB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants