Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add current working directory as first config path #291

Merged
merged 1 commit into from Sep 26, 2022

Conversation

blink1073
Copy link
Member

Fixes #228

@jasongrout
Copy link
Member

Thanks!

@jasongrout jasongrout merged commit 810ceb7 into jupyter:main Sep 26, 2022
@ccordoba12
Copy link

ccordoba12 commented Sep 29, 2022

I think this will introduce CVE-2022-21699 in projects that rely on Jupyter-core, so perhaps it should be reverted?

@kevin-bates
Copy link
Member

I just installed the pre-release and am finding that lab/workspaces is being created in my home directory, abandoning the same already in ~/.jupyter. With the switch to platformdirs, there's an opt-in element for the 5.x release. Is this worthy of the same? Otherwise, folks will "lose" their current settings and those settings are now visible (by default) if their root-dir happens to be their home directory.

@blink1073 blink1073 deleted the fix-paths-output branch October 28, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jupyter --paths incorrect output
4 participants