Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyyaml version 3.13 listed as High severity risk by Github audit. #819

Closed
kbroughton opened this issue Feb 28, 2019 · 6 comments
Closed
Labels
tag:Security Related to security, vulnerabilities tag:Upstream A problem with one of the upstream packages installed in the docker images

Comments

@kbroughton
Copy link

Hi! Thanks for using the Jupyter Docker Stacks.

If you are looking to contribute to the images, please see the [Contributor's Guide] (http://jupyter-docker-stacks.readthedocs.io/en/latest/#) in the documentation for our preferred processes.

If you are reporting an issue with one of the existing images, please answer the questions below to help us troubleshoot the problem. Please be as thorough as possible.

What docker image you are using?
jupyter/scipy-notebook

What complete docker command do you run to launch the container (omitting sensitive values)?
docker build -t jupyter/scipy-notebook .

What steps do you take once the container is running to reproduce the issue?
The following step in the build has output which lists pyyaml 3.13 as a package to be installed.

step 7/13 : RUN conda install --quiet --yes 'conda-forge::blas==openblas' 'ipywidgets=7.4' 'pandas=0.23*' 'numexpr=2.6*' 'matplotlib=2.2*' 'scipy=1.1*' 'seaborn=0.9*' 'scikit-learn=0.20*' 'scikit-image=0.14*' 'sympy=1.1*' 'cython=0.28*' 'patsy=0.5*' 'statsmodels=0.9*' 'cloudpickle=0.5*' 'dill=0.2*' 'dask=1.1.' 'numba=0.38' 'bokeh=0.13*' 'sqlalchemy=1.2*' 'hdf5=1.10*' 'h5py=2.7*' 'vincent=0.4.' 'beautifulsoup4=4.6.' 'protobuf=3.*' 'xlrd' && conda remove --quiet --yes --force qt pyqt && conda clean -tipsy

Two issues here.

  1. Github flags pyyaml 3.13 as High severity.
  2. Installing other packages like azure-cli-core requires pyyaml > 4.2b1 and the 3.13 version
    can't be upgraded due to a distutils error.

What do you expect to happen?

Expect pyyaml to run a newer version without the High Severity vuln.

What actually happens?
Builds with pyyaml 3.13

...

@parente
Copy link
Member

parente commented Feb 28, 2019

Looks like a version bump of all the scipy packages is in order. Happy to take a PR with version increases or I'll try to get to it on a weekend.

@parente
Copy link
Member

parente commented Mar 8, 2019

pyyaml                             3.13-py37h14c3975_1001

still gets pulled in after updating packages in #822. Looking at conda-forge, the pyyaml feedstock is still at 3.13 as is the latest release on PyPI. The PyYAML home page also says the latest version is 3.13.

@kbroughton can you confirm what you saw in the GitHub alert and the output from installing azure-cli-core?

@parente parente added status:Need Info We believe we need more information about an issue from the reporting user to help, debug, fix and removed tag:Security Related to security, vulnerabilities labels Mar 8, 2019
@parente
Copy link
Member

parente commented Mar 8, 2019

Found out what's going on here: yaml/pyyaml#193 (comment)

@parente
Copy link
Member

parente commented Mar 8, 2019

And here's the PR that will merge into 5.1 release with the fix: yaml/pyyaml#257 Until then, 3.13 is the supported release version.

@parente parente added tag:Upstream A problem with one of the upstream packages installed in the docker images tag:Security Related to security, vulnerabilities and removed status:Need Info We believe we need more information about an issue from the reporting user to help, debug, fix labels Mar 8, 2019
@kbroughton
Copy link
Author

thanks for digging!

@parente
Copy link
Member

parente commented Mar 31, 2019

Looking at https://github.com/jupyter/docker-stacks/wiki/scipy-notebook-59b402ce701d today, I see that the image contains pyyaml 5.1. Other images I spot check downstream of scipy-notebook also seem to have pyyaml 5.1. I'm going to close this out as fixed upstream.

@parente parente closed this as completed Mar 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:Security Related to security, vulnerabilities tag:Upstream A problem with one of the upstream packages installed in the docker images
Projects
None yet
Development

No branches or pull requests

2 participants