From 5bcd59e6fd4baa3a900b35f06e380e414e293dcc Mon Sep 17 00:00:00 2001 From: Divyansh Choudhary Date: Sat, 26 Mar 2022 20:35:57 +0530 Subject: [PATCH 1/2] Add `max-age` Cache-Control header to kernel logos Issue: #702 --- jupyter_server/kernelspecs/handlers.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/jupyter_server/kernelspecs/handlers.py b/jupyter_server/kernelspecs/handlers.py index 437670d90a..8c4a46052c 100644 --- a/jupyter_server/kernelspecs/handlers.py +++ b/jupyter_server/kernelspecs/handlers.py @@ -19,6 +19,8 @@ def initialize(self): @authorized def get(self, kernel_name, path, include_body=True): ksm = self.kernel_spec_manager + if path.lower().endswith(".png"): + self.set_header("Cache-Control", "max-age=1000") try: self.root = ksm.get_kernel_spec(kernel_name).resource_dir except KeyError as e: From 69b11f75d508a98d4b7bcbcdce31057553538f99 Mon Sep 17 00:00:00 2001 From: Divyansh Choudhary Date: Mon, 28 Mar 2022 12:03:36 +0530 Subject: [PATCH 2/2] Increase kernel image ttl to one month --- jupyter_server/kernelspecs/handlers.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jupyter_server/kernelspecs/handlers.py b/jupyter_server/kernelspecs/handlers.py index 8c4a46052c..3ff130f3b6 100644 --- a/jupyter_server/kernelspecs/handlers.py +++ b/jupyter_server/kernelspecs/handlers.py @@ -20,7 +20,7 @@ def initialize(self): def get(self, kernel_name, path, include_body=True): ksm = self.kernel_spec_manager if path.lower().endswith(".png"): - self.set_header("Cache-Control", "max-age=1000") + self.set_header("Cache-Control", f"max-age={60*60*24*30}") try: self.root = ksm.get_kernel_spec(kernel_name).resource_dir except KeyError as e: