Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix server-extension paths (3rd time's the charm) #734

Merged
merged 2 commits into from Mar 14, 2022

Conversation

minrk
Copy link
Contributor

@minrk minrk commented Mar 14, 2022

reverts #732 with fix for MultipleInstanceErrors

Copy link
Collaborator

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@minrk
Copy link
Contributor Author

minrk commented Mar 14, 2022

❤️ sorry for the headaches!

@blink1073
Copy link
Collaborator

❤️ sorry for the headaches!

Haha no worries, this is a tricky one

@blink1073 blink1073 merged commit 461b551 into jupyter-server:main Mar 14, 2022
@blink1073
Copy link
Collaborator

Drat, I merged this too early it seems, it hadn't finished the Install from SDist and Test job, which now hangs at exit. I'm not going to hold up the release though.

@minrk minrk deleted the revert-revert branch March 15, 2022 09:06
blink1073 added a commit to blink1073/jupyter_server that referenced this pull request Mar 15, 2022
blink1073 added a commit to blink1073/jupyter_server that referenced this pull request Mar 15, 2022
Revert "Fix server-extension paths (3rd time's the charm) (jupyter-server#734)"

This reverts commit 461b551.

Revert "Revert "Fix server-extension paths (3rd time's the charm) (jupyter-server#734)""

This reverts commit d6fdebc.
blink1073 added a commit to blink1073/jupyter_server that referenced this pull request Mar 15, 2022
Revert "Fix server-extension paths (3rd time's the charm) (jupyter-server#734)"

This reverts commit 461b551.

Revert "Revert "Fix server-extension paths (3rd time's the charm) (jupyter-server#734)""

This reverts commit d6fdebc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants