Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't let ContentsHandler's internal 404 bubble up. #1328

Closed
Carreau opened this issue Sep 23, 2023 · 4 comments
Closed

Don't let ContentsHandler's internal 404 bubble up. #1328

Carreau opened this issue Sep 23, 2023 · 4 comments

Comments

@Carreau
Copy link
Contributor

Carreau commented Sep 23, 2023

See jupyterlab/jupyterlab#15153

ContentsHandler's get requests (and future HEAD requests #1327) should likely catch internal 404s and return a clean 404 with 'set_status()' and finish() this will avoid tornado to print tracebacks on non-existing files, which are often requested on purpose, like in SaveAs.

@Zsailer
Copy link
Member

Zsailer commented Oct 12, 2023

Yeah, I agree here, @Carreau. Thank you for raising here. I've labeled the issue with "good first issue" since this should be fairly strait forward.

@bloomsa
Copy link
Contributor

bloomsa commented Nov 7, 2023

can this be assigned to me? I'll give it a shot

@bloomsa
Copy link
Contributor

bloomsa commented Dec 3, 2023

FYI I think this can be closed now that #1357 is merged. let me know if I'm wrong

@Carreau
Copy link
Contributor Author

Carreau commented Dec 3, 2023

Likely, let's close.

@Carreau Carreau closed this as completed Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants