Add repeatable capabilities for @..Source annotations #3787
+638
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcphilipp
reviewed
Apr 19, 2024
junit-jupiter-params/src/main/java/org/junit/jupiter/params/provider/CSVSources.java
Outdated
Show resolved
Hide resolved
...ter-params/src/main/java/org/junit/jupiter/params/support/AnnotationConsumerInitializer.java
Outdated
Show resolved
Hide resolved
...ter-params/src/main/java/org/junit/jupiter/params/support/AnnotationConsumerInitializer.java
Outdated
Show resolved
Hide resolved
...jupiter-params/src/test/java/org/junit/jupiter/params/ParameterizedTestIntegrationTests.java
Outdated
Show resolved
Hide resolved
...s/src/main/java/org/junit/jupiter/params/provider/RepeatableAnnotationArgumentsProvider.java
Outdated
Show resolved
Hide resolved
junit-jupiter-params/src/main/java/org/junit/jupiter/params/provider/CSVSources.java
Outdated
Show resolved
Hide resolved
madalingiurca
pushed a commit
to madalingiurca/junit5
that referenced
this pull request
Apr 19, 2024
marcphilipp
requested changes
Apr 25, 2024
documentation/src/docs/asciidoc/release-notes/release-notes-5.11.0-M1.adoc
Outdated
Show resolved
Hide resolved
junit-jupiter-params/src/main/java/org/junit/jupiter/params/provider/CsvFileSources.java
Outdated
Show resolved
Hide resolved
...jupiter-params/src/test/java/org/junit/jupiter/params/ParameterizedTestIntegrationTests.java
Show resolved
Hide resolved
added 14 commits
April 25, 2024 17:29
…ntsProvider into one provider
madalingiurca
force-pushed
the
issue/3736
branch
from
9b40389
to
0acecf1
Compare
madalingiurca
force-pushed
the
issue/3736
branch
from
08b9a93
to
66454ab
Compare
marcphilipp
requested changes
May 8, 2024
| @Target(ElementType.METHOD) | ||
| @Retention(RetentionPolicy.RUNTIME) | ||
| @Documented | ||
| @API(status = STABLE, since = "5.11") |
There was a problem hiding this comment.
This should be experimental like @FieldSource
Suggested change
| @API(status = STABLE, since = "5.11") | |
| @API(status = EXPERIMENTAL, since = "5.11") |
There was a problem hiding this comment.
ah, true. Changed it to experimental in 7a0f7f1
There was a problem hiding this comment.
I think we should change the first sentence of the Javadoc here and for the other source annotation to mention that they're repeatable:
* {@code @CsvFileSource} is a {@linkplain Repeatable repeatable}
* {@link ArgumentsSource} which is used to load comma-separated value (CSV)
* files from one or more classpath {@link #resources} or {@link #files}.There was a problem hiding this comment.
Makes sense. Repeatable mention added for all 6 changed annotations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
These changes aim to add capabilities of repeatable
@..Sourceannotations. Solves #3736.Repeatable capabilities added to every annotation that makes use of
AnnotationBasedArgumentsProviderby adapting to accept multiple annotations while aggregating the result of each annotation arguments.Helper class
AnnotationConsumerInitializerneeds adaptations as well in order to invoke initialization for each annotation if repeatable.This change does not affect annotations related to null and/or empty sources:
@NullSource,@EmptySourceand@NullAndEmptySource. This makes sense since they have predefined/hardcoded arguments relevant to null and empty collections.I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations