Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce AssertionFailureBuilder #2972

Merged
merged 6 commits into from Jul 17, 2022
Merged

Introduce AssertionFailureBuilder #2972

merged 6 commits into from Jul 17, 2022

Conversation

marcphilipp
Copy link
Member

@marcphilipp marcphilipp commented Jul 8, 2022 •
edited

Overview

Resolves #2967.

I hereby agree to the terms of the JUnit Contributor License Agreement.

Definition of Done

@marcphilipp marcphilipp force-pushed the marc/2967-assertion-builder branch 2 times, most recently from 283916f to 17d4144 Compare July 10, 2022 12:54
@marcphilipp marcphilipp changed the title [WIP] Introduce AssertionBuilder Introduce AssertionFailureBuilder Jul 10, 2022
@marcphilipp marcphilipp added this to the 5.9 GA milestone Jul 10, 2022
@marcphilipp marcphilipp marked this pull request as ready for review July 10, 2022 13:30
@marcphilipp marcphilipp mentioned this pull request Jul 10, 2022
Closed
1 task
@marcphilipp marcphilipp removed this from the 5.9 GA milestone Jul 10, 2022
bechte
bechte reviewed Jul 15, 2022
View reviewed changes
Copy link
Contributor

@bechte bechte left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added two questions, most likely the missing calls to cause should be added. Otherwise, I approve this PR.

junit-jupiter-api/src/main/java/org/junit/jupiter/api/AssertThrowsExactly.java Show resolved Hide resolved
junit-jupiter-api/src/main/java/org/junit/jupiter/api/AssertThrows.java Show resolved Hide resolved
@marcphilipp marcphilipp merged commit e91e5dc into main Jul 17, 2022
@marcphilipp marcphilipp deleted the marc/2967-assertion-builder branch July 17, 2022 16:27
@marcphilipp marcphilipp self-assigned this Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bechte bechte bechte left review comments

@sbrannen sbrannen sbrannen approved these changes

@mamadaliev mamadaliev mamadaliev approved these changes

Assignees

@marcphilipp marcphilipp

Labels
component: Jupiter theme: extensions theme: programming model type: new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The class org.junit.jupiter.api.AssertionUtils and its methods should be public
4 participants
@marcphilipp @sbrannen @bechte @mamadaliev