Fix container failure XML reporting #2542
Merged
+221
−126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, failing containers were only reported in case they contained at least one test. However, for example for a parameterized Jupiter tests and an exception in a `@BeforeAll` method, that led to failures being silently swallowed. Now, in addition to tests, leaf nodes of the test tree are always included in the XML report, even if they are containers, not tests. Fixes #2537.
Prior to this commit, failures on the container level that occur after their children have been executed were not reported, e.g. when an exception was thrown from a Jupiter `@AfterAll` method. Now such failures cause the contained tests to be reported as failed.
Codecov Report
@@ Coverage Diff @@
## main #2542 +/- ##
============================================
+ Coverage 90.54% 90.57% +0.03%
- Complexity 4713 4721 +8
============================================
Files 413 413
Lines 11653 11665 +12
Branches 924 921 -3
============================================
+ Hits 10551 10566 +15
Misses 825 825
+ Partials 277 274 -3
Continue to review full report at Codecov.
|
marcphilipp
deleted the
marc/2537-always-include-failures-in-xml-report
branch
marcphilipp
added a commit
that referenced
this pull request
Feb 1, 2021
Prior to this commit, failing containers were only reported in case they contained at least one test. However, for example for a parameterized Jupiter tests and an exception in a `@BeforeAll` method, that led to failures being silently swallowed. Now, in addition to tests, leaf nodes of the test tree are always included in the XML report, even if they are containers, not tests. Moreover, failures on the container level that occurred after their children had been executed were not reported, e.g. when an exception was thrown from a Jupiter `@AfterAll` method. Now such failures cause the contained tests to be reported as failed. Fixes #2537.
mpkorstanje
pushed a commit
to mpkorstanje/junit5
that referenced
this pull request
Feb 6, 2021
Prior to this commit, failing containers were only reported in case they contained at least one test. However, for example for a parameterized Jupiter tests and an exception in a `@BeforeAll` method, that led to failures being silently swallowed. Now, in addition to tests, leaf nodes of the test tree are always included in the XML report, even if they are containers, not tests. Moreover, failures on the container level that occurred after their children had been executed were not reported, e.g. when an exception was thrown from a Jupiter `@AfterAll` method. Now such failures cause the contained tests to be reported as failed. Fixes junit-team#2537.
This was referenced Mar 13, 2021
Merged
runningcode
pushed a commit
to runningcode/junit5
that referenced
this pull request
Feb 15, 2023
Prior to this commit, failing containers were only reported in case they contained at least one test. However, for example for a parameterized Jupiter tests and an exception in a `@BeforeAll` method, that led to failures being silently swallowed. Now, in addition to tests, leaf nodes of the test tree are always included in the XML report, even if they are containers, not tests. Moreover, failures on the container level that occurred after their children had been executed were not reported, e.g. when an exception was thrown from a Jupiter `@AfterAll` method. Now such failures cause the contained tests to be reported as failed. Fixes junit-team#2537.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see individual commits.
Fixes #2537.