Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow parallel execution of child nodes if only read locks are acquired #2423

Closed
1 task done
leonard84 opened this issue Sep 24, 2020 · 3 comments · Fixed by #2515
Closed
1 task done

Allow parallel execution of child nodes if only read locks are acquired #2423

leonard84 opened this issue Sep 24, 2020 · 3 comments · Fixed by #2515
Assignees
@leonard84
Labels
component: Platform status: in progress theme: concurrency
Milestone
5.7.2

Comments

@leonard84
Copy link
Collaborator

leonard84 commented Sep 24, 2020 •
edited by marcphilipp

Currently, child nodes are forced to SAME_THREAD execution if the parent has any locks.

If the parent only has READ locks, then it would be valid for the child nodes to execute concurrently. This would also alleviate the issues of #2038 and we partly have this logic already for the isolated execution of #2142

Deliverables

  • Don't force child nodes to SAME_THREAD execution if only READ locks are acquired
@marcphilipp
Copy link
Member

SGTM. Would you like to send a PR?

@marcphilipp marcphilipp added this to the 5.8 M1 milestone Sep 25, 2020
@leonard84 leonard84 self-assigned this Sep 28, 2020
@XN137
Copy link

XN137 commented Oct 11, 2020

is this still actively being worked on?
if no, i might be willing to take a stab at this

@leonard84
Copy link
Collaborator Author

@XN137 go ahead, I still have some stuff to finish over at https://github.com/spockframework/spock before I get to this

leonard84 added a commit to leonard84/junit5 that referenced this issue Jan 4, 2021
@leonard84
Allow parallel execution of child nodes if only read locks are acquired
f132c89 
fixes junit-team#2423
@leonard84 leonard84 mentioned this issue Jan 4, 2021
Merged
7 tasks
marcphilipp added a commit that referenced this issue May 15, 2021
@marcphilipp
Move #2423 to 5.7.2
0ba600e
@marcphilipp marcphilipp modified the milestones: 5.8 M1, 5.7.2 May 15, 2021
marcphilipp added a commit that referenced this issue May 15, 2021
@marcphilipp
Move #2423 to 5.7.2
a589243
@sync-by-unito sync-by-unito bot mentioned this issue May 17, 2021
Closed
@marcphilipp marcphilipp mentioned this issue Jun 26, 2022
Closed
1 task
@mpkorstanje mpkorstanje mentioned this issue Jul 24, 2022
Closed
runningcode pushed a commit to runningcode/junit5 that referenced this issue Feb 15, 2023
@marcphilipp @runningcode
Move junit-team#2423 to 5.7.2
c06b6af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leonard84 leonard84

Labels
component: Platform status: in progress theme: concurrency
Projects
None yet
Milestone
5.7.2
Development

Successfully merging a pull request may close this issue.

Allow parallel execution of child nodes if only read locks are acquired leonard84/junit5
3 participants
@marcphilipp @leonard84 @XN137