Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close resource in inverse order of addition #2387

Merged
merged 2 commits into from Aug 20, 2020

Conversation

marcphilipp
Copy link
Member

@marcphilipp marcphilipp commented Aug 18, 2020

Resolves #2211.


I hereby agree to the terms of the JUnit Contributor License Agreement.


Definition of Done

@marcphilipp marcphilipp self-assigned this Aug 18, 2020
@codecov
Copy link

codecov bot commented Aug 18, 2020

Codecov Report

❗ No coverage uploaded for pull request base (main@10aef49). Click here to learn what that means.
The diff coverage is 96.42%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2387   +/-   ##
=======================================
  Coverage        ?   89.89%           
  Complexity      ?     4552           
=======================================
  Files           ?      397           
  Lines           ?    11247           
  Branches        ?      907           
=======================================
  Hits            ?    10110           
  Misses          ?      863           
  Partials        ?      274           
Impacted Files Coverage Δ Complexity Δ
.../junit/jupiter/api/extension/ExtensionContext.java 92.00% <ø> (ø) 6.00 <0.00> (?)
...jupiter/engine/execution/ExtensionValuesStore.java 90.78% <96.29%> (ø) 25.00 <15.00> (?)
...junit/platform/testkit/engine/EventConditions.java 97.87% <100.00%> (ø) 33.00 <1.00> (?)
...rams/aggregator/ArgumentsAggregationException.java 50.00% <0.00%> (ø) 1.00% <0.00%> (?%)
...ain/java/org/junit/platform/engine/TestEngine.java 53.84% <0.00%> (ø) 3.00% <0.00%> (?%)
...iter/api/extension/TestInstantiationException.java 100.00% <0.00%> (ø) 2.00% <0.00%> (?%)
...intage/engine/discovery/ClassSelectorResolver.java 100.00% <0.00%> (ø) 13.00% <0.00%> (?%)
.../params/support/AnnotationConsumerInitializer.java 70.58% <0.00%> (ø) 6.00% <0.00%> (?%)
...iter/engine/descriptor/MethodExtensionContext.java 100.00% <0.00%> (ø) 9.00% <0.00%> (?%)
...junit/jupiter/api/parallel/ResourceAccessMode.java 100.00% <0.00%> (ø) 1.00% <0.00%> (?%)
... and 390 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10aef49...1c142d3. Read the comment docs.

Copy link
Member

@sormuras sormuras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcphilipp marcphilipp force-pushed the issues/2211-close-resources-order branch from 740361e to 1c142d3 Compare August 20, 2020 19:48
@marcphilipp marcphilipp marked this pull request as ready for review August 20, 2020 20:00
@marcphilipp marcphilipp merged commit 68bb2e3 into main Aug 20, 2020
@marcphilipp marcphilipp deleted the issues/2211-close-resources-order branch August 20, 2020 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CloseableResource invocation order
2 participants