Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add junit5-jupiter-starter-graalvm-native sample #176

Open
sormuras opened this issue Sep 16, 2022 · 5 comments
Open

Add junit5-jupiter-starter-graalvm-native sample #176

sormuras opened this issue Sep 16, 2022 · 5 comments

Comments

@sormuras
Copy link
Member

Add minimal working example building a native "hello world" application and running Jupiter tests against it.

@marcphilipp
Copy link
Member

I don't think we should duplicate what https://github.com/graalvm/native-build-tools/tree/master/samples/java-application-with-tests already provides.

@sbrannen sbrannen changed the title Add junit5-jupiter-starter-graalvm sample Add junit5-jupiter-starter-graalvm-native sample Sep 17, 2022
@sbrannen
Copy link
Member

I renamed the proposed project name to *-native since we're really showcasing native image testing support and not GraalVM as an alternative JVM.

@sbrannen
Copy link
Member

I don't think we should duplicate what https://github.com/graalvm/native-build-tools/tree/master/samples/java-application-with-tests already provides.

Good point.

There's not much value in duplicating that.

Plus it already includes Gradle and Maven build support.

Instead of having our own example, we could just link to that one.

@marcphilipp
Copy link
Member

Instead of having our own example, we could just link to that one.

From the readme? Or should we also include it in the user guide?

@sbrannen
Copy link
Member

From the readme? Or should we also include it in the user guide?

Both: in the README for the junit5-samples project and in the JUnit 5 user guide.

Since we just added @DisabledInNativeImage support (which links to the NBT project), I think it would make sense to add minimal documentation about running tests in a native image. I guess that would go in the "Running Tests" section, probably under build tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants