Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix StdIo and ReportEntry to target ANNOTATION_TYPE #698

Merged
merged 1 commit into from Nov 30, 2022
Merged

Fix StdIo and ReportEntry to target ANNOTATION_TYPE #698

merged 1 commit into from Nov 30, 2022

Conversation

Michael1993
Copy link
Member

@Michael1993 Michael1993 commented Nov 28, 2022 •
edited

Proposed commit message:

 Fix StdIo and ReportEntry not targeting ANNOTATION_TYPE (#696 / #698)

This commit fixes the annotations @ReportEntry and @StdIo missing
the ANNOTATION_TYPE or TYPE from their @Target. They can now be used
on composed annotations.

Closes: #696
PR: #698

Closes #696

@Michael1993 Michael1993 added the full-build Triggers full build suite on PR label Nov 29, 2022
@eeverman
Copy link
Contributor

Thank you!

@nipafx
Copy link
Member

nipafx commented Nov 30, 2022

Good work @eeverman for finding this and reporting and @Michael1993 for fixing! 👍🏾

@nipafx nipafx merged commit 63c82ed into main Nov 30, 2022
@nipafx nipafx deleted the issue-696/composed-annotations branch November 30, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
full-build Triggers full build suite on PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for composed annotations to all annotations
3 participants
@Michael1993 @eeverman @nipafx