Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #686 Support gradle 7.6-rc-3 #687

Merged
merged 1 commit into from Nov 15, 2022

Conversation

carterkozak
Copy link
Contributor

@carterkozak carterkozak commented Nov 14, 2022

Closes: #686

Proposed commit message:

Fix compile error in build.gradle.kts on Gradle 7.6 (#686 / #687)

`JvmComponentDependencies` changed:

* [Before (7.5.1)](https://github.com/gradle/gradle/blob/v7.5.1/subprojects/plugins/src/main/java/org/gradle/api/plugins/jvm/JvmComponentDependencies.java#L46)
* [After (7.6.0-RC3)](https://github.com/gradle/gradle/blob/v7.6.0-RC3/subprojects/plugins/src/main/java/org/gradle/api/plugins/jvm/JvmComponentDependencies.java#L48)

Closes: #686
PR: #687

PR checklist

The following checklist shall help the PR's author, the reviewers and maintainers to ensure the quality of this project.
It is based on our contributors guidelines, especially the "writing code" section.
It shall help to check for completion of the listed points.
If a point does not apply to the given PR's changes, the corresponding entry can be simply marked as done.

Documentation (general)

  • There is documentation (Javadoc and site documentation; added or updated)
  • There is implementation information to describe why a non-obvious source code / solution got implemented
  • Site documentation has its own .adoc file in the docs folder, e.g. docs/report-entries.adoc
  • Site documentation in .adoc file references demo in src/demo/java instead of containing code blocks as text
  • Only one sentence per line (especially in .adoc files)
  • Javadoc uses formal style, while sites documentation may use informal style

Documentation (new extension)

  • The docs/docs-nav.yml navigation has an entry for the new extension
  • The package-info.java contains information about the new extension

Code

  • Code adheres to code style, naming conventions etc.
  • Successful tests cover all changes
  • There are checks which validate correct / false usage / configuration of a functionality and there are tests to verify those checks
  • Tests use AssertJ or our own PioneerAssert (which are based on AssertJ)

Contributing

  • A prepared commit message exists
  • The list of contributions inside README.md mentions the new contribution (real name optional)

@beatngu13 beatngu13 added the full-build Triggers full build suite on PR label Nov 14, 2022
@beatngu13
Copy link
Member

@carterkozak thank you for your contribution! I have just triggered the full build to see how this change behaves.

Copy link
Member

@Michael1993 Michael1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds are green, LGTM

@Bukama Bukama merged commit 2645d29 into junit-pioneer:main Nov 15, 2022
@Bukama
Copy link
Member

Bukama commented Nov 15, 2022

What a verbose syntax change...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full-build Triggers full build suite on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix compile error in build.gradle.kts on Gradle 7.6
4 participants