Rename "merge-ready" label to "full-build" #679
Labels
⚙️ component: Pioneer
Issues about Pioneer own things (e.g. utils)
🚦 status: in progress
📖 theme: build
🏗️ type: task
🛸 3rd-party: Github Actions
Milestone
Comments
Bukama
added
📖 theme: build
🏗️ type: task
⚙️ component: Pioneer
|
Doesn't need a discussion IMO. Let's rename it! |
|
I agree, we should rename it. But lets wait for the build crew to hear their opinion. 😉 |
|
Not strong opinion regarding that ;) I do agree it makes more sense ;) |
nipafx
changed the title
nipafx
pushed a commit
that referenced
this issue
Nov 10, 2022
Switching from the reduced, faster build to the full build of all Java/OS/etc combinations requires adding a specific label to the PR. It was called "merge-ready", which marks the PR as being ready to be merged once the build is green, but that is (at least) occasionally not the case. To avoid confusion, we rename the label to the less leading name "full-build". Closes: #679 PR: #682
14 tasks
nipafx
added a commit
that referenced
this issue
Nov 10, 2022
Switching from the reduced, faster build to the full build of all Java/OS/etc combinations requires adding a specific label to the PR. It was called "merge-ready", which marks the PR as being ready to be merged once the build is green, but that is (at least) occasionally not the case. To avoid confusion, we rename the label to the less leading name "full-build". Closes: #679 PR: #682
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The wording "merge-ready" label is misleading since we restructured our build scripts as it's only there to trigger the full build (e.g. for testing purposes), regardless if the PR is ready to merge or not.
In Discord @nipafx suggested to rename it to "full-build". This issue is to discuss it here on Github
The text was updated successfully, but these errors were encountered: