Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outdated documentation with @CartesianTest #665

Closed
Michael1993 opened this issue Sep 9, 2022 · 0 comments · Fixed by #666
Closed

Outdated documentation with @CartesianTest #665

Michael1993 opened this issue Sep 9, 2022 · 0 comments · Fixed by #666
Labels
⚙️ component: Pioneer Issues about Pioneer own things (e.g. utils) good first issue 🚦 status: in progress 📖 theme: documentation 🏗️ type: task 📢 up for grabs
Milestone
Busy Pioneers - V2.0

Comments

@Michael1993
Copy link
Member

The static factory method part says that it must be static but the demo snippets feature non-static factory methods.
@Bukama Bukama added this to the Busy Pioneers - V2.0 milestone Sep 10, 2022
@nipafx nipafx linked a pull request Sep 14, 2022 that will close this issue
Improve Cartesian test documentation #666
Merged
14 tasks
Bukama pushed a commit that referenced this issue Sep 19, 2022
@nipafx
Improve Cartesian test documentation (#665 / #666)
2038be8 
`@CartesianTest.MethodFactory`-annotated methods can be non-static
under certain circumstances, but the demo snippets showed non-static
factory methods that didn't match these and were thus wrong. This
change fixes that, which required moving the factory methods from
non-static inner classes into the outer class. For conistency and to
make things easier in the future, the same was done for all other
snippets as well.

The snippets were prepended with imports, which was incoherent when
the snippets turned from classes to just methods. Hence the imports
were removed as well, which has the eadded benefit of not having to
maintain the imports and making the snippets shorter.

Closes: #665
PR: #666
Bukama pushed a commit to Bukama/junit-pioneer that referenced this issue Sep 20, 2022
@nipafx @Bukama
Improve Cartesian test documentation (junit-pioneer#665 / junit-pione…
ab0eebd 
…er#666)

`@CartesianTest.MethodFactory`-annotated methods can be non-static
under certain circumstances, but the demo snippets showed non-static
factory methods that didn't match these and were thus wrong. This
change fixes that, which required moving the factory methods from
non-static inner classes into the outer class. For conistency and to
make things easier in the future, the same was done for all other
snippets as well.

The snippets were prepended with imports, which was incoherent when
the snippets turned from classes to just methods. Hence the imports
were removed as well, which has the eadded benefit of not having to
maintain the imports and making the snippets shorter.

Closes: junit-pioneer#665
PR: junit-pioneer#666
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
⚙️ component: Pioneer Issues about Pioneer own things (e.g. utils) good first issue 🚦 status: in progress 📖 theme: documentation 🏗️ type: task 📢 up for grabs
Projects
None yet
Milestone
Busy Pioneers - V2.0
Development

Successfully merging a pull request may close this issue.

Improve Cartesian test documentation junit-pioneer/junit-pioneer
3 participants
@Michael1993 @Bukama @nipafx